zy-kkk commented on code in PR #46912:
URL: https://github.com/apache/doris/pull/46912#discussion_r1950486312
##########
be/src/vec/exec/vjdbc_connector.cpp:
##########
@@ -119,23 +119,13 @@ Status JdbcConnector::open(RuntimeState* state, bool
read) {
// Add a scoped cleanup jni reference object. This cleans up local refs
made below.
JniLocalFrame jni_frame;
{
- std::string local_location;
- std::hash<std::string> hash_str;
- auto* function_cache = UserFunctionCache::instance();
- if (_conn_param.resource_name.empty()) {
- // for jdbcExternalTable, _conn_param.resource_name == ""
- // so, we use _conn_param.driver_path as key of jarpath
- SCOPED_RAW_TIMER(&_jdbc_statistic._load_jar_timer);
- RETURN_IF_ERROR(function_cache->get_jarpath(
- std::abs((int64_t)hash_str(_conn_param.driver_path)),
_conn_param.driver_path,
- _conn_param.driver_checksum, &local_location));
+ std::string driver_path;
+
+ if (_conn_param.driver_path.find(":/") == std::string::npos) {
+ driver_path = "file://" + config::jdbc_drivers_dir + "/" +
_conn_param.driver_path;
Review Comment:
I added a path check on the FE side. The Driver URL is always sent by FE to
BE, so BE is only responsible for processing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
