This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/branch-2.1 by this push:
     new c8ccada010a branch-2.1: [Fix](memory) Add try catch block for 
`Segment::load_pk_index_and_bf`… (#47742)
c8ccada010a is described below

commit c8ccada010a3cf149e943bdecd21ee7993f336bf
Author: bobhan1 <bao...@selectdb.com>
AuthorDate: Tue Feb 11 16:56:13 2025 +0800

    branch-2.1: [Fix](memory) Add try catch block for 
`Segment::load_pk_index_and_bf`… (#47742)
    
    pick https://github.com/apache/doris/pull/47715
---
 be/src/olap/rowset/segment_v2/segment.cpp | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/be/src/olap/rowset/segment_v2/segment.cpp 
b/be/src/olap/rowset/segment_v2/segment.cpp
index 9126a081d54..1f98eafd6fc 100644
--- a/be/src/olap/rowset/segment_v2/segment.cpp
+++ b/be/src/olap/rowset/segment_v2/segment.cpp
@@ -25,6 +25,7 @@
 #include <memory>
 #include <utility>
 
+#include "common/exception.h"
 #include "common/logging.h"
 #include "common/status.h"
 #include "io/fs/file_reader.h"
@@ -327,8 +328,13 @@ Status Segment::_load_pk_bloom_filter() {
 }
 
 Status Segment::load_pk_index_and_bf() {
-    RETURN_IF_ERROR(load_index());
-    RETURN_IF_ERROR(_load_pk_bloom_filter());
+    // `DorisCallOnce` may catch exception in calling stack A and re-throw it 
in
+    // a different calling stack B which doesn't have catch block. So we add 
catch block here
+    // to prevent coreudmp
+    RETURN_IF_CATCH_EXCEPTION({
+        RETURN_IF_ERROR(load_index());
+        RETURN_IF_ERROR(_load_pk_bloom_filter());
+    });
     return Status::OK();
 }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to