morrySnow commented on code in PR #47595:
URL: https://github.com/apache/doris/pull/47595#discussion_r1950270778
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -849,10 +849,10 @@ optionWithoutType
| (CHAR SET | CHARSET) (charsetName=identifierOrText | DEFAULT)
#setCharset
| NAMES (charsetName=identifierOrText | DEFAULT)
(COLLATE collateName=identifierOrText | DEFAULT)?
#setCollate
- | PASSWORD (FOR userIdentify)? EQ (STRING_LITERAL
- | (isPlain=PASSWORD LEFT_PAREN STRING_LITERAL RIGHT_PAREN))
#setPassword
- | LDAP_ADMIN_PASSWORD EQ (STRING_LITERAL
- | (PASSWORD LEFT_PAREN STRING_LITERAL RIGHT_PAREN))
#setLdapAdminPassword
+ | PASSWORD (FOR userIdentify)? EQ (pwd=STRING_LITERAL
+ | (isPlain=PASSWORD LEFT_PAREN pwd=STRING_LITERAL RIGHT_PAREN))
#setPassword
Review Comment:
wrong indentation here
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -849,10 +849,10 @@ optionWithoutType
| (CHAR SET | CHARSET) (charsetName=identifierOrText | DEFAULT)
#setCharset
| NAMES (charsetName=identifierOrText | DEFAULT)
(COLLATE collateName=identifierOrText | DEFAULT)?
#setCollate
- | PASSWORD (FOR userIdentify)? EQ (STRING_LITERAL
- | (isPlain=PASSWORD LEFT_PAREN STRING_LITERAL RIGHT_PAREN))
#setPassword
- | LDAP_ADMIN_PASSWORD EQ (STRING_LITERAL
- | (PASSWORD LEFT_PAREN STRING_LITERAL RIGHT_PAREN))
#setLdapAdminPassword
+ | PASSWORD (FOR userIdentify)? EQ (pwd=STRING_LITERAL
+ | (isPlain=PASSWORD LEFT_PAREN pwd=STRING_LITERAL RIGHT_PAREN))
#setPassword
+ | LDAP_ADMIN_PASSWORD EQ (pwd=STRING_LITERAL
+ | (PASSWORD LEFT_PAREN pwd=STRING_LITERAL RIGHT_PAREN))
#setLdapAdminPassword
Review Comment:
wrong indentation here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
