starocean999 commented on code in PR #47594: URL: https://github.com/apache/doris/pull/47594#discussion_r1948468951
########## fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java: ########## @@ -5214,6 +5216,31 @@ public LogicalPlan visitDropRole(DropRoleContext ctx) { return new DropRoleCommand(ctx.name.getText(), ctx.EXISTS() != null); } + @Override + public LogicalPlan visitDropTable(DropTableContext ctx) { + String ctlName = null; + String dbName = null; + String tableName = null; + List<String> nameParts = visitMultipartIdentifier(ctx.name); + if (nameParts.size() == 1) { + tableName = nameParts.get(0); + } else if (nameParts.size() == 2) { + dbName = nameParts.get(0); + tableName = nameParts.get(1); + } else if (nameParts.size() == 3) { + ctlName = nameParts.get(0); + dbName = nameParts.get(1); + tableName = nameParts.get(2); + } else { + throw new AnalysisException("nameParts in create table should be [ctl.][db.]tbl"); + } + + boolean ifExists = ctx.EXISTS() != null; + boolean forceDrop = ctx.FORCE() != null; + TableName tblName = new TableName(ctlName, dbName, tableName); Review Comment: Use TableNameInfo instead of old TableName -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org