amorynan commented on code in PR #47627:
URL: https://github.com/apache/doris/pull/47627#discussion_r1947543741
##########
be/src/vec/functions/function_json.cpp:
##########
@@ -571,7 +571,7 @@ struct JsonParser<'1'> {
StringRef data,
rapidjson::Document::AllocatorType& allocator) {
DCHECK(data.size == 1 || strncmp(data.data, "true", 4) == 0 ||
strncmp(data.data, "false", 5) == 0);
- value.SetBool((*data.data == '1' || *data.data == 't') ? true : false);
+ value.SetBool(*data.data == '1' || *data.data == 't');
Review Comment:
they are same semantics and the modify behavior just from my code advisor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
