HappenLee commented on code in PR #47364:
URL: https://github.com/apache/doris/pull/47364#discussion_r1947539440
##########
be/src/pipeline/exec/analytic_sink_operator.cpp:
##########
@@ -845,7 +847,9 @@ Status
AnalyticSinkOperatorX::_insert_range_column(vectorized::Block* block,
RETURN_IF_ERROR(expr->execute(block, &result_col_id));
DCHECK_GE(result_col_id, 0);
auto column =
block->get_by_position(result_col_id).column->convert_to_full_column_if_const();
- dst_column->insert_range_from(*column, 0, length);
+ // iff dst_column is string, maybe overflow of 4G, so need ignore overflow
+ // the column is used by compare_at self to find the range, it's need
convert it when overflow?
Review Comment:
why here is ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
