yiguolei commented on code in PR #45375:
URL: https://github.com/apache/doris/pull/45375#discussion_r1946315946
##########
be/src/pipeline/exec/exchange_sink_operator.cpp:
##########
@@ -239,10 +290,7 @@ Status ExchangeSinkLocalState::open(RuntimeState* state) {
}
}
- if (_part_type == TPartitionType::HASH_PARTITIONED ||
- _part_type == TPartitionType::BUCKET_SHFFULE_HASH_PARTITIONED ||
- _part_type == TPartitionType::TABLE_SINK_HASH_PARTITIONED ||
- _part_type == TPartitionType::TABLET_SINK_SHUFFLE_PARTITIONED) {
+ if (_partitioner) {
Review Comment:
如果这里partitioner 可能为空，我们后续很多操作都会引入这个partitoner的判断。
我们可不可以引入一个donothing的partitioner，这样我们默认值就是这个donothing或者叫dummy
之类的，这样我们后续的代码就不用判断这个是否为空了。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
