morrySnow commented on code in PR #1970:
URL: https://github.com/apache/doris-website/pull/1970#discussion_r1944594047
##########
docs/sql-manual/sql-functions/scalar-functions/conditional-functions/coalesce.md:
##########
@@ -24,24 +24,36 @@ specific language governing permissions and limitations
under the License.
-->
-## coalesce
-### description
-#### Syntax
+## Description
-`coalesce(expr1, expr2, ...., expr_n)`
+Returns the first non-null expression from left to right in the parameter
list. If all arguments are NULL, returns NULL.
+## Syntax
-Returns the first non empty expression in the parameter (from left to right)
+```sql
+COALESCE(expr1, expr2, ..., expr_n)
Review Comment:
1. 参数用尖括号包裹
2. 变长参数用 `[, ...]`
```suggestion
COALESCE(<expr> [, ...])
```
##########
docs/sql-manual/sql-functions/scalar-functions/conditional-functions/coalesce.md:
##########
@@ -24,24 +24,36 @@ specific language governing permissions and limitations
under the License.
-->
-## coalesce
-### description
-#### Syntax
+## Description
-`coalesce(expr1, expr2, ...., expr_n)`
+Returns the first non-null expression from left to right in the parameter
list. If all arguments are NULL, returns NULL.
+## Syntax
-Returns the first non empty expression in the parameter (from left to right)
+```sql
+COALESCE(expr1, expr2, ..., expr_n)
+```
+
+## Parameters
+
+| Parameter | Description
|
+| -------------- |
----------------------------------------------------------------------------- |
+| expr1 ~ expr_n | A sequence of expressions to evaluate. All expressions must
be compatible data types. |
Review Comment:
```suggestion
| `<expr>` | A sequence of expressions to evaluate. All expressions must be
compatible data types. |
```
##########
docs/sql-manual/sql-functions/scalar-functions/conditional-functions/if.md:
##########
@@ -24,27 +24,33 @@ specific language governing permissions and limitations
under the License.
-->
-## if
-### description
-#### Syntax
+## Description
-`if(boolean condition, type valueTrue, type valueFalseOrNull)`
+Returns `valueTrue` when the condition is true, and returns `valueFalseOrNull`
otherwise. The return type is determined by the result of the
`valueTrue`/`valueFalseOrNull` expression.
+## Syntax
-Returns valueTrue when condition is true, returns valueFalseOrNull otherwise.
+```sql
+IF(boolean condition, type valueTrue, type valueFalseOrNull)
Review Comment:
1. 参数用尖括号包裹
2. 参数名用全小写，下划线分隔
3. 不要参数类型
```suggestion
IF(<condition>, <value_true>, <value_false_or_null>)
```
##########
docs/sql-manual/sql-functions/scalar-functions/conditional-functions/ifnull.md:
##########
@@ -24,31 +24,54 @@ specific language governing permissions and limitations
under the License.
-->
-## ifnull
-### description
-#### Syntax
+## Description
-`ifnull(expr1, expr2)`
+Returns `<expr1>` if it is not `NULL`; otherwise, returns `<expr2>`.
+## Alias
-If the value of expr1 is not null, expr1 is returned, otherwise expr2 is
returned
+- DSQRT
Review Comment:
这个别名写错了吧，应该是 NVL
##########
docs/sql-manual/sql-functions/scalar-functions/conditional-functions/least.md:
##########
@@ -22,45 +23,73 @@ specific language governing permissions and limitations
under the License.
-->
-## least
+## Description
+
+Compares multiple expressions and returns the smallest value among them. If
any parameter is `NULL`, the function returns `NULL`.
+
+## Syntax
+
+```sql
+LEAST(<expr1>, <expr2>, ..., <exprN>)
Review Comment:
同 GREATEST
##########
docs/sql-manual/sql-functions/scalar-functions/conditional-functions/greatest.md:
##########
@@ -22,45 +24,73 @@ specific language governing permissions and limitations
under the License.
-->
-## greatest
+## Description
+
+Compares multiple expressions and returns the greatest value among them. If
any argument is `NULL`, the function returns `NULL`.
+
+## Syntax
+
+```sql
+GREATEST(<expr1>, <expr2>, ..., <exprN>)
Review Comment:
同上
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
