HappenLee commented on code in PR #47389:
URL: https://github.com/apache/doris/pull/47389#discussion_r1944053405
##########
be/src/util/mysql_row_buffer.cpp:
##########
@@ -379,14 +442,13 @@ int MysqlRowBuffer<is_binary_format>::push_time(double
data) {
template <bool is_binary_format>
int MysqlRowBuffer<is_binary_format>::push_timev2(double data, int scale) {
if (is_binary_format && !_dynamic_mode) {
- char buff[8];
+ char buff[13];
_field_pos++;
- float8store(buff, data);
- return append(buff, 8);
+ int length = encode_binary_timev2(buff, data, scale);
+ return append(buff, length);
}
- // 1 for string trail, 1 for length, other for time str
- reserve(2 + MAX_TIME_WIDTH);
+ reserve(2 + MAX_TIME_WIDTH);
Review Comment:
`2 + MAX_TIME_WIDTH` == 12， but the buff is 13 maybe core in the corner case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
