[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #10278: [Improvement] remove olap filters when use in key ranges

[GitBox]

BiteTheDDDDt commented on code in PR #10278:
URL: https://github.com/apache/doris/pull/10278#discussion_r903354340


##########
be/src/exec/olap_common.h:
##########
@@ -258,6 +258,9 @@ class OlapScanKeys {
     template <class T>
     Status extend_scan_key(ColumnValueRange<T>& range, int32_t 
max_scan_key_num);
 
+    template <class T>
+    Status extend_scan_key(ColumnValueRange<T>& range, int32_t 
max_scan_key_num, bool* exact_value);
+

Review Comment:
   I agree with zenoyang‘s opinion, but maybe we can also modify row-based 
code? It doesn't look like much work.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org