morrySnow commented on code in PR #1924:
URL: https://github.com/apache/doris-website/pull/1924#discussion_r1942192717
##########
docs/sql-manual/sql-functions/scalar-functions/string-functions/regexp-extract-all.md:
##########
@@ -24,17 +24,24 @@ specific language governing permissions and limitations
under the License.
-->
-## regexp_extract_all
-### Description
-#### Syntax
+## Description
+
+Regularly matches a string `str` and extracts the first sub-pattern matching
part of `pattern`. The pattern needs to exactly match a part of `str` in order
to return an array of strings for the part of the pattern that needs to be
matched. If there is no match or the pattern has no sub-pattern, the empty
string is returned.
+
+- Character set matching requires the use of Unicode standard character
classes. For example, to match Chinese, use `\p{Han}`.
+
+## Syntax
`VARCHAR regexp_extract_all (VARCHAR str, VARCHAR pattern)`
-Regularly matches a string str and extracts the first sub-pattern matching
part of pattern. The pattern needs to exactly match a part of str in order to
return an array of strings for the part of the pattern that needs to be
matched. If there is no match or the pattern has no sub-pattern, the empty
string is returned.
+## Parameters
-Character set matching requires the use of Unicode standard character classes.
For example, to match Chinese, use `\p{Han}`.
+| Parameter | Description |
+| -- | -- |
+| `str` | The column need to do regular matching.|
Review Comment:
```suggestion
| `<str>` | The column need to do regular matching.|
```
##########
docs/sql-manual/sql-functions/scalar-functions/string-functions/regexp-extract-all.md:
##########
@@ -24,17 +24,24 @@ specific language governing permissions and limitations
under the License.
-->
-## regexp_extract_all
-### Description
-#### Syntax
+## Description
+
+Regularly matches a string `str` and extracts the first sub-pattern matching
part of `pattern`. The pattern needs to exactly match a part of `str` in order
to return an array of strings for the part of the pattern that needs to be
matched. If there is no match or the pattern has no sub-pattern, the empty
string is returned.
+
+- Character set matching requires the use of Unicode standard character
classes. For example, to match Chinese, use `\p{Han}`.
+
+## Syntax
`VARCHAR regexp_extract_all (VARCHAR str, VARCHAR pattern)`
Review Comment:
1. 使用 code block，而不是 inline code
2. 不要参数和返回值类型
3. 函数名大写
4. 参数用尖括号包裹
````suggestion
```sql
regexp_extract_all
REGEXP_EXTRACT_ALL(<str>, <pattern>)
```
````
##########
docs/sql-manual/sql-functions/scalar-functions/string-functions/regexp-extract-all.md:
##########
@@ -24,17 +24,24 @@ specific language governing permissions and limitations
under the License.
-->
-## regexp_extract_all
-### Description
-#### Syntax
+## Description
+
+Regularly matches a string `str` and extracts the first sub-pattern matching
part of `pattern`. The pattern needs to exactly match a part of `str` in order
to return an array of strings for the part of the pattern that needs to be
matched. If there is no match or the pattern has no sub-pattern, the empty
string is returned.
+
+- Character set matching requires the use of Unicode standard character
classes. For example, to match Chinese, use `\p{Han}`.
+
+## Syntax
`VARCHAR regexp_extract_all (VARCHAR str, VARCHAR pattern)`
-Regularly matches a string str and extracts the first sub-pattern matching
part of pattern. The pattern needs to exactly match a part of str in order to
return an array of strings for the part of the pattern that needs to be
matched. If there is no match or the pattern has no sub-pattern, the empty
string is returned.
+## Parameters
-Character set matching requires the use of Unicode standard character classes.
For example, to match Chinese, use `\p{Han}`.
+| Parameter | Description |
+| -- | -- |
+| `str` | The column need to do regular matching.|
+| `pattern` | Target pattern.|
Review Comment:
```suggestion
| `<pattern>` | Target pattern.|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
