gavinchou commented on code in PR #47475:
URL: https://github.com/apache/doris/pull/47475#discussion_r1930658998
##########
cloud/src/recycler/recycler.cpp:
##########
@@ -1521,25 +1521,28 @@ int InstanceRecycler::delete_rowset_data(const
std::vector<doris::RowsetMetaClou
InvertedIndexInfo index_info;
int get_ret =
inverted_index_id_cache_->get(rs.index_id(),
rs.schema_version(), index_info);
- if (get_ret != 0) {
- if (get_ret == 1) { // Schema kv not found
- // Check tablet existence
- std::string tablet_idx_key, tablet_idx_val;
- meta_tablet_idx_key({instance_id_, tablet_id},
&tablet_idx_key);
- if (txn_get(txn_kv_.get(), tablet_idx_key, tablet_idx_val)
== 1) {
- // Tablet has been recycled, rowset data has already
been deleted
- std::lock_guard lock(recycled_tablets_mtx_);
- recycled_tablets_.insert(tablet_id);
- continue;
- }
+ if (get_ret == 0) {
+ index_format = index_info.first;
+ index_ids = std::move(index_info.second);
+ } else if (get_ret == 1) {
+ // Schema kv not found means tablet has been recycled
+ // Maybe some tablet recycle failed by some bugs
+ // We need to delete again to double check
+ LOG_INFO(
+ "delete rowset data schema kv not found, need to
delete again to double "
+ "check")
+ .tag("instance_id", instance_id_)
+ .tag("tablet_id", tablet_id)
+ .tag("rowset", rs.ShortDebugString());
+ for (int64_t i = 0; i < num_segments; ++i) {
Review Comment:
redundant path with line 1553 line 1554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
