zhiqiang-hhhh commented on code in PR #44690: URL: https://github.com/apache/doris/pull/44690#discussion_r1926761284
########## be/src/vec/exec/scan/scanner_context.cpp: ########## @@ -277,19 +272,15 @@ void ScannerContext::push_back_scan_task(std::shared_ptr<ScanTask> scan_task) { } } } - std::lock_guard<std::mutex> l(_transfer_lock); - if (!scan_task->status_ok()) { - _process_status = scan_task->get_status(); - } - if (_last_scale_up_time == 0) { - _last_scale_up_time = UnixMillis(); - } - if (_tasks_queue.empty() && _last_fetch_time != 0) { - // there's no block in queue before current block, so the consumer is waiting - _total_wait_block_time += UnixMillis() - _last_fetch_time; + + { + std::lock_guard<std::mutex> l(_transfer_lock); + if (!scan_task->status_ok()) { + _process_status = scan_task->get_status(); + } + _tasks_queue.push_back(scan_task); Review Comment: 在 push_back_scan_task 之前会执行 _num_scheduled_scanners-- > _num_scheduled_scanners-- 不需要了吗? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org