morrySnow commented on code in PR #9954:
URL: https://github.com/apache/doris/pull/9954#discussion_r901537140
##########
fe/fe-core/src/main/java/org/apache/doris/planner/OlapScanNode.java:
##########
@@ -893,7 +893,6 @@ private void filterDeletedRows(Analyzer analyzer) throws
AnalysisException {
SlotRef deleteSignSlot = new SlotRef(desc.getAliasAsName(),
Column.DELETE_SIGN);
deleteSignSlot.analyze(analyzer);
deleteSignSlot.getDesc().setIsMaterialized(true);
-
deleteSignSlot.getDesc().setIsNullable(analyzer.isOuterMaterializedJoined(desc.getId()));
Review Comment:
we also need to remove `setIsNullable` in [Analyzer#registerColumnRef
](https://github.com/apache/doris/blob/b7b78ae7079a61eadab0e78d9e9c9792dd0af1b3/fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java#L796)
##########
gensrc/thrift/PlanNodes.thrift:
##########
@@ -409,6 +409,10 @@ struct THashJoinNode {
// hash output column
6: optional list<Types.TSlotId> hash_output_slot_ids
+
+ 7: optional list<Exprs.TExpr> srcExprList
+
+ 8: optional Types.TTupleId voutput_tuple_id
Review Comment:
move it to TPlanNode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
