morrySnow commented on code in PR #46910:
URL: https://github.com/apache/doris/pull/46910#discussion_r1925385447


##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -204,6 +204,7 @@ supportedCreateStatement
 supportedAlterStatement
     : ALTER VIEW name=multipartIdentifier (LEFT_PAREN cols=simpleColumnDefs 
RIGHT_PAREN)?
         AS query                                                          
#alterView
+    | ALTER VIEW name=multipartIdentifier MODIFY COMMENT 
comment=STRING_LITERAL     #alterViewComment

Review Comment:
   ```suggestion
       | ALTER VIEW name=multipartIdentifier MODIFY commentSpec     
#alterViewComment
   ```



##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/PlanType.java:
##########
@@ -183,6 +183,7 @@ public enum PlanType {
     ALTER_CATALOG_RENAME_COMMAND,
     ALTER_ROLE_COMMAND,
     ALTER_VIEW_COMMAND,
+    ALTER_VIEW_COMMENT_COMMAND,

Review Comment:
   maybe should like alter table, use one command to do both change query and 
change command



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to