morrySnow commented on code in PR #1910:
URL: https://github.com/apache/doris-website/pull/1910#discussion_r1925193129
##########
docs/sql-manual/sql-statements/account-management/REVOKE-FROM.md:
##########
@@ -24,74 +24,163 @@ specific language governing permissions and limitations
under the License.
-->
-
## Description
The REVOKE command has the following functions:
1. Revoke the specified permission of a user or a role.
2. Revoke the specified role previously granted to a user.
->Note that.
->
->"Revoke the specified roles previously granted to a user" is supported in
versions 2.0 and later
+**Related Commands**
+
+- [GRANT TO](./GRANT-TO.md)
+- [SHOW
GRANTS](../../../sql-manual/sql-statements/account-management/SHOW-GRANTS.md)
+- [CREATE ROLE](./CREATE-ROLE.md)
+- [CREATE WORKLOAD
GROUP](../cluster-management/compute-management/CREATE-WORKLOAD-GROUP.md)
+- [CREATE
RESOURCE](../cluster-management/compute-management/CREATE-RESOURCE.md)
+- [CREATE STORAGE
VAULT](../cluster-management/storage-management/CREATE-STORAGE-VAULT.md)
+
+## Syntax
+
+**Revoke the specified permission of a user or a role**
```sql
-REVOKE privilege_list ON db_name[.tbl_name] FROM user_identity [ROLE role_name]
+REVOKE <privilege_list> ON { <priv_level> | RESOURCE <resource_name> |
WORKLOAD GROUP <workload_group_name> | COMPUTE GROUP <compute_group_name> |
STORAGE VAULT <storage_vault_name> } FROM { <user_identity> | ROLE <role_name> }
Review Comment:
折行
##########
docs/sql-manual/sql-statements/account-management/SHOW-PROPERTY.md:
##########
@@ -7,108 +7,134 @@
<!--
Licensed to the Apache Software Foundation (ASF) under one
-or more contributor license agreements. See the NOTICE file
+or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
-regarding copyright ownership. The ASF licenses this file
+regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
-with the License. You may obtain a copy of the License at
+with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-KIND, either express or implied. See the License for the
+KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
-
## Description
-This statement is used to view the attributes of the user
-
-```
-SHOW PROPERTY [FOR user] [LIKE key]
-SHOW ALL PROPERTIES [LIKE key]
-```
-
-* `user`
-
- View the attributes of the specified user. If not specified, check the
current user's.
+This statement is used to view the attributes of the user.
-* `LIKE`
-
- Fuzzy matching can be done by attribute name.
-
-* `ALL`
-
- View the properties of all users (supported since version 2.0.3)
-
-Return result description:
+## Syntax
```sql
-mysql> show property like'%connection%';
-+----------------------+-------+
-| Key | Value |
-+----------------------+-------+
-| max_user_connections | 100 |
-+----------------------+-------+
-1 row in set (0.01 sec)
+SHOW {ALL PROPERTIES | PROPERTY [FOR <user_name>]} [LIKE <key>]
```
-* `Key`
Review Comment:
需要介绍 ALL PROPERTIES 是什么意义
##########
docs/sql-manual/sql-statements/account-management/GRANT-TO.md:
##########
@@ -25,31 +24,39 @@ specific language governing permissions and limitations
under the License.
-->
-
## Description
The GRANT command is used to:
1. Grant specified privileges to a user or role.
2. Grant specified roles to a user.
-## Syntax
+**Related Commands**
-GRANT privilege_list ON priv_level TO user_identity [ROLE role_name]
+- [REVOKE FROM](./REVOKE-FROM.md)
+- [SHOW
GRANTS](../../../sql-manual/sql-statements/account-management/SHOW-GRANTS.md)
+- [CREATE ROLE](./CREATE-ROLE.md)
+- [CREATE WORKLOAD
GROUP](../cluster-management/compute-management/CREATE-WORKLOAD-GROUP.md)
+- [CREATE
RESOURCE](../cluster-management/compute-management/CREATE-RESOURCE.md)
+- [CREATE STORAGE
VAULT](../cluster-management/storage-management/CREATE-STORAGE-VAULT.md)
-GRANT privilege_list ON RESOURCE resource_name TO user_identity [ROLE
role_name]
+## Syntax
-GRANT privilege_list ON WORKLOAD GROUP workload_group_name TO user_identity
[ROLE role_name]
+**Grant specified privileges to a user or role**
-GRANT privilege_list ON COMPUTE GROUP compute_group_name TO user_identity
[ROLE role_name]
+```sql
+GRANT <privilege_list> ON { <priv_level> | RESOURCE <resource_name> | WORKLOAD
GROUP <workload_group_name> | COMPUTE GROUP <compute_group_name> | STORAGE
VAULT <storage_vault_name> } TO { <user_identity> | ROLE <role_name> }
Review Comment:
这行太长了，折一折行
##########
docs/sql-manual/sql-statements/account-management/SHOW-GRANTS.md:
##########
@@ -25,45 +25,96 @@ under the License.
-->
+
+
Review Comment:
无意义的空行 删掉吧
##########
docs/sql-manual/sql-statements/account-management/SHOW-GRANTS.md:
##########
@@ -25,45 +25,96 @@ under the License.
-->
+
+
## Description
- This statement is used to view user permissions.
+ This statement is used to view user permissions.
-grammar:
+## Syntax
```sql
-SHOW [ALL] GRANTS [FOR user_identity];
+SHOW [ALL] GRANTS [FOR <user_identity>];
```
-illustrate:
+## Optional Parameters
Review Comment:
需要在可选参数中介绍 `[ALL]` 的意义
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
