zhannngchen commented on code in PR #47028:
URL: https://github.com/apache/doris/pull/47028#discussion_r1924968223
##########
be/src/olap/base_tablet.cpp:
##########
@@ -1876,4 +1876,34 @@ Status BaseTablet::show_nested_index_file(std::string*
json_meta) {
return Status::OK();
}
+void BaseTablet::get_base_rowset_delete_bitmap_count(
+ uint64_t* max_base_rowset_delete_bitmap_score,
+ int64_t* max_base_rowset_delete_bitmap_score_tablet_id) {
+ std::vector<RowsetSharedPtr> rowsets_;
+ std::string base_rowset_id_str;
+ {
+ std::shared_lock rowset_ldlock(this->get_header_lock());
+ for (const auto& it : _rs_version_map) {
+ rowsets_.emplace_back(it.second);
+ }
+ }
+ std::sort(rowsets_.begin(), rowsets_.end(), Rowset::comparator);
+ if (!rowsets_.empty()) {
+ for (auto& rowset : rowsets_) {
+ if (rowset->start_version() > 2) {
Review Comment:
should LOG(WARNING) here, that means there's some bugs on choosing base
rowset
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
