BiteTheDDDDt commented on code in PR #47265:
URL: https://github.com/apache/doris/pull/47265#discussion_r1924762214
##########
be/src/runtime/descriptors.h:
##########
@@ -53,7 +54,7 @@ class PSlotDescriptor;
class SlotDescriptor {
public:
- // virtual ~SlotDescriptor() {};
+ MOCK_DEFINE(virtual ~SlotDescriptor() = default;)
Review Comment:
‘;)’ seems a little bit weird
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
