BiteTheDDDDt commented on code in PR #47176:
URL: https://github.com/apache/doris/pull/47176#discussion_r1923067357
##########
be/src/vec/sink/vdata_stream_sender.cpp:
##########
@@ -175,7 +175,7 @@ Status Channel::_send_current_block(bool eos) {
Status Channel::_send_local_block(bool eos) {
Block block;
if (_serializer.get_block() != nullptr) {
- block = _serializer.get_block()->to_block();
+ block = std::move(*_serializer.get_block()).to_block();
_serializer.get_block()->set_mutable_columns(block.clone_empty_columns());
Review Comment:
use mutable block after moved seems a bit tricky. better use a new object
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
