morrySnow commented on code in PR #1875: URL: https://github.com/apache/doris-website/pull/1875#discussion_r1921855178
########## docs/sql-manual/sql-functions/aggregate-functions/any-value.md: ########## @@ -24,29 +24,39 @@ specific language governing permissions and limitations under the License. --> -## ANY_VALUE +## description -ANY_VALUE +Returns any value from the expression or column in the group. If there is a non-NULL value, it returns any non-NULL value; otherwise, it returns NULL. +## Alias -### description -#### Syntax +`ANY` Review Comment: 使用无序列表 ```suggestion - ANY ``` ########## docs/sql-manual/sql-functions/aggregate-functions/array-agg.md: ########## @@ -24,26 +24,31 @@ specific language governing permissions and limitations under the License. --> -## ARRAY_AGG +## description -### description +Concatenates the values (including null values) in a column into an array, which can be used for pivoting rows into columns. -#### Syntax +## Syntax `ARRAY_AGG(col)` -Concatenation of values in a column (including the null value) into an array can be used for multiple rows to one row (row to column). +## Parameters -### notice +| Parameter | Description | +| -- | -- | +| `col` | An expression that determines the values to be placed into the array (usually column names). | Review Comment: ```suggestion | `<col>` | An expression that determines the values to be placed into the array (usually column names). | ``` ########## docs/sql-manual/sql-functions/aggregate-functions/array-agg.md: ########## @@ -24,26 +24,31 @@ specific language governing permissions and limitations under the License. --> -## ARRAY_AGG +## description -### description +Concatenates the values (including null values) in a column into an array, which can be used for pivoting rows into columns. -#### Syntax +## Syntax `ARRAY_AGG(col)` Review Comment: 1. 使用 code block 不要使用 inline code 2. 参数使用尖括号包裹 ````suggestion ```sql ARRAY_AGG(<col>) ``` ```` ########## docs/sql-manual/sql-functions/aggregate-functions/array-agg.md: ########## @@ -79,6 +88,7 @@ mysql> select c1, array_agg(c2) from test_doris_array_agg group by c1; +------+-----------------+ ``` -### keywords +## notice Review Comment: 这个章节的内容直接放到描述里面和返回值章节 ########## docs/sql-manual/sql-functions/aggregate-functions/array-agg.md: ########## @@ -24,26 +24,31 @@ specific language governing permissions and limitations under the License. --> -## ARRAY_AGG +## description Review Comment: ```suggestion ## Description ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org