morrySnow commented on code in PR #1825: URL: https://github.com/apache/doris-website/pull/1825#discussion_r1921765346
########## docs/sql-manual/sql-functions/aggregate-functions/intersect-count.md: ########## Review Comment: 这个文档 Description 部分和 Syntax 部分忘记修改了 ########## docs/sql-manual/sql-functions/scalar-functions/string-functions/format.md: ########## @@ -29,6 +29,7 @@ under the License. Returns a formatted string using the specified [format](https://fmt.dev/11.1/syntax/#format-specification-mini-language) string and arguments: ## Syntax + ```sql String format(String format, args ...) Review Comment: 1. 不需要参数和返回值类型 2. 参数需要用尖括号包裹 3. 可选部分需要用方括号包裹 4. 函数名大写 ```suggestion FORMAT(<format>, <args> [, ... ] ) ``` ########## docs/sql-manual/sql-functions/scalar-functions/numeric-functions/abs.md: ########## @@ -23,21 +23,14 @@ under the License. --> -### description +## description Returns the absolute value of `x` -#### Syntax +## Syntax ```sql -SMALLINT abs(TINYINT x) -INT abs(SMALLINT x) -BIGINT abs(INT x) -LARGEINT abs(BIGINT x) -LARGEINT abs(LARGEINT x) -DOUBLE abs(DOUBLE x) -FLOAT abs(FLOAT x) -DECIMAL abs(DECIMAL x)` +abs(<x>) Review Comment: 函数名大写 ```suggestion ABS(<x>) ``` ########## docs/sql-manual/sql-functions/aggregate-functions/intersect-count.md: ########## @@ -44,16 +47,20 @@ mysql [test]>select dt,bitmap_to_string(user_id) from pv_bitmap; | 4 | 1,2,3,4,5 | | 3 | 1,2,3 | +------+---------------------------+ -4 rows in set (0.02 sec) +``` + +```sql +select intersect_count(user_id,dt,3,4) from pv_bitmap; +``` -mysql [test]>select intersect_count(user_id,dt,3,4) from pv_bitmap; +```text +------------------------------------+ | intersect_count(user_id, dt, 3, 4) | +------------------------------------+ | 3 | +------------------------------------+ ``` -### keywords +## keywords Review Comment: 不需要 keywords 章节。直接删掉 ########## docs/sql-manual/sql-functions/scalar-functions/string-functions/parse_data_size.md: ########## @@ -30,7 +30,7 @@ Parse a string in the format of "value + unit" and convert the value into a numb If the input parameter is invalid, an error will be raised. The maximum return value is Int128 Max. -Data Storage Unit Table +## Data Storage Unit Table Review Comment: 这里属于描述的一部分，不要单独搞一个章节。用加粗就可以 ```suggestion ** Data Storage Unit Table ** ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
