This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch spill_and_reserve
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/spill_and_reserve by this push:
new 2c8848eee61 add comment
2c8848eee61 is described below
commit 2c8848eee61c25a10289b67a9f9405c099bbb41b
Author: yiguolei <guo...@selectdb.com>
AuthorDate: Sat Jan 18 21:10:36 2025 +0800
add comment
---
be/src/pipeline/pipeline_task.cpp | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/be/src/pipeline/pipeline_task.cpp
b/be/src/pipeline/pipeline_task.cpp
index e09da6ab742..f7fd34f8f6f 100644
--- a/be/src/pipeline/pipeline_task.cpp
+++ b/be/src/pipeline/pipeline_task.cpp
@@ -432,6 +432,9 @@ Status PipelineTask::execute(bool* eos) {
GlobalMemoryArbitrator::process_mem_log_str());
}
LOG_EVERY_N(INFO, 100) << debug_msg;
+ // If reserve failed, not add this query to paused list,
because it is very small, will not
+ // consume a lot of memory. But need set low memory mode
to indicate that the system should
+ // not use too much memory.
_state->get_query_ctx()->set_low_memory_mode();
}
}
@@ -472,7 +475,8 @@ Status PipelineTask::execute(bool* eos) {
debug_msg += fmt::format(", debug info: {}",
GlobalMemoryArbitrator::process_mem_log_str());
}
-
+ // If the operator is not spillable or it is spillable but
not has much memory to spill
+ // not need add to paused list, just let it go.
if (_sink->revocable_mem_size(_state) >=
_state->spill_min_revocable_mem()) {
VLOG_DEBUG << debug_msg;
DCHECK_EQ(_pending_block.get(), nullptr);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
