Kikyou1997 commented on code in PR #10240:
URL: https://github.com/apache/doris/pull/10240#discussion_r900735365
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/ExprId.java:
##########
@@ -17,13 +17,15 @@
package org.apache.doris.nereids.trees.expressions;
+import org.apache.doris.common.Id;
+
import java.util.Objects;
import java.util.UUID;
/**
* UUID for Expression in Nereids.
*/
-public class ExprId {
+public class ExprId extends Id<ExprId> {
private final long id;
private final UUID jvmId;
Review Comment:
And removed the jvmId by the way
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/PlaceHolderPlan.java:
##########
@@ -81,4 +85,34 @@ public PlaceHolderPlan withChildren(List<Plan> children) {
Preconditions.checkArgument(children.size() == 0);
return new PlaceHolderPlan(logicalProperties);
}
+
+ @Override
+ public List<? extends PlanStats> getChildrenStats() {
+ return null;
+ }
+
+ @Override
+ public StatsDeriveResult getStatsDeriveResult() {
+ return null;
+ }
+
+ @Override
+ public StatisticalType getNodeType() {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
