yiguolei commented on code in PR #10161: URL: https://github.com/apache/doris/pull/10161#discussion_r899946704
########## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ########## @@ -914,6 +914,7 @@ void SegmentIterator::_evaluate_short_circuit_predicate(uint16_t* vec_sel_rowid_ predicate->type() == PredicateType::GT || predicate->type() == PredicateType::GE) { col_ptr->convert_dict_codes_if_necessary(); } + predicate->set_dict_code_if_necessary(*short_cir_column, _segment->id()); Review Comment: Segment id is unique in a single rowset, it is not unique between different rowsets. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org