Sjwhello commented on code in PR #47066:
URL: https://github.com/apache/doris/pull/47066#discussion_r1918112102
##########
fe/fe-core/src/main/java/org/apache/doris/common/cache/NereidsSqlCacheManager.java:
##########
@@ -350,13 +344,26 @@ private boolean tablesOrDataChanged(Env env,
SqlCacheContext sqlCacheContext) {
return true;
}
OlapTable olapTable = (OlapTable) tableIf;
- Collection<Long> partitionIds = scanTable.getScanPartitions();
- olapTable.getVersionInBatchForCloudMode(partitionIds);
-
- for (Long scanPartitionId : scanTable.getScanPartitions()) {
- Partition partition = olapTable.getPartition(scanPartitionId);
+ List<Column> currentFullSchema = olapTable.getFullSchema();
+ List<Column> cacheFullSchema = scanTable.latestColumns;
+ if (currentFullSchema.size() != cacheFullSchema.size()) {
+ return true;
+ }
+ for (int i = 0; i < currentFullSchema.size(); i++) {
+ Column currentColumn = currentFullSchema.get(i);
+ Column cacheColumn = cacheFullSchema.get(i);
+ if (currentColumn.hashCode() != cacheColumn.hashCode()) {
+ return true;
+ }
+ }
+ Map<Long, Long> scanPartitionIdToVersion =
scanTable.scanPartitionIdToVersion;
+ for (Entry<Long, Long> entry :
scanPartitionIdToVersion.entrySet()) {
+ Long scanPartitionId = entry.getKey();
+ Long cachePartitionVersion = entry.getValue();
+ Partition currentPartition =
olapTable.getPartition(scanPartitionId);
Review Comment:
> get partition one by one will lead to bad perfermance in cloud mode
Isn't this in-memory data? Do we have to redo it every time?
##########
fe/fe-core/src/main/java/org/apache/doris/common/cache/NereidsSqlCacheManager.java:
##########
@@ -350,13 +344,26 @@ private boolean tablesOrDataChanged(Env env,
SqlCacheContext sqlCacheContext) {
return true;
}
OlapTable olapTable = (OlapTable) tableIf;
- Collection<Long> partitionIds = scanTable.getScanPartitions();
- olapTable.getVersionInBatchForCloudMode(partitionIds);
-
- for (Long scanPartitionId : scanTable.getScanPartitions()) {
- Partition partition = olapTable.getPartition(scanPartitionId);
+ List<Column> currentFullSchema = olapTable.getFullSchema();
+ List<Column> cacheFullSchema = scanTable.latestColumns;
+ if (currentFullSchema.size() != cacheFullSchema.size()) {
+ return true;
+ }
+ for (int i = 0; i < currentFullSchema.size(); i++) {
+ Column currentColumn = currentFullSchema.get(i);
+ Column cacheColumn = cacheFullSchema.get(i);
+ if (currentColumn.hashCode() != cacheColumn.hashCode()) {
+ return true;
+ }
+ }
+ Map<Long, Long> scanPartitionIdToVersion =
scanTable.scanPartitionIdToVersion;
+ for (Entry<Long, Long> entry :
scanPartitionIdToVersion.entrySet()) {
+ Long scanPartitionId = entry.getKey();
+ Long cachePartitionVersion = entry.getValue();
+ Partition currentPartition =
olapTable.getPartition(scanPartitionId);
Review Comment:
Isn't this in-memory data? Do we have to redo it every time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
