BiteTheDDDDt commented on code in PR #10211:
URL: https://github.com/apache/incubator-doris/pull/10211#discussion_r899790405
##########
be/src/olap/in_list_predicate.h:
##########
@@ -338,15 +338,29 @@ class InListPredicateBase : public ColumnPredicate {
}
}
- if constexpr (is_opposite != (PT == PredicateType::IN_LIST)) {
Review Comment:
Maybe we can just change `is_opposite != (PT == PredicateType::IN_LIST)` to
`!is_opposite`.
Or change it to
```cpp
if (is_opposite ^
_operator(_values.find(reinterpret_cast<const
T&>(data_array[idx])),
_values.end())) {
sel[new_size++] = idx;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
