This is an automated email from the ASF dual-hosted git repository.
panxiaolei pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.0 by this push:
new d606557685d [Bug](runtime-filter) fix core dump on rf between varchar
and char #43758 (#46966)
d606557685d is described below
commit d606557685d6a9b34662200edcae264cf38b4898
Author: Pxl <x...@selectdb.com>
AuthorDate: Tue Jan 14 15:23:03 2025 +0800
[Bug](runtime-filter) fix core dump on rf between varchar and char #43758
(#46966)
pick from #43758
---
be/src/exprs/bloom_filter_func.h | 1 +
be/src/exprs/create_predicate_function.h | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/be/src/exprs/bloom_filter_func.h b/be/src/exprs/bloom_filter_func.h
index 6810c265947..12f1ee34869 100644
--- a/be/src/exprs/bloom_filter_func.h
+++ b/be/src/exprs/bloom_filter_func.h
@@ -213,6 +213,7 @@ public:
_bloom_filter_alloced = other_func->_bloom_filter_alloced;
_bloom_filter = other_func->_bloom_filter;
_inited = other_func->_inited;
+ set_filter_id(bloomfilter_func->get_filter_id());
}
virtual void insert(const void* data) = 0;
diff --git a/be/src/exprs/create_predicate_function.h
b/be/src/exprs/create_predicate_function.h
index a96565b55db..596608e9e82 100644
--- a/be/src/exprs/create_predicate_function.h
+++ b/be/src/exprs/create_predicate_function.h
@@ -233,7 +233,8 @@ ColumnPredicate* create_olap_column_predicate(uint32_t
column_id,
std::shared_ptr<BloomFilterFuncBase> filter_olap;
filter_olap.reset(create_bloom_filter(PT));
filter_olap->light_copy(filter.get());
- return new BloomFilterColumnPredicate<PT>(column_id, filter,
be_exec_version);
+ // create a new filter to match the input filter and PT. For example,
filter may be varchar, but PT is char
+ return new BloomFilterColumnPredicate<PT>(column_id, filter_olap,
be_exec_version);
}
template <PrimitiveType PT>
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
