cambyzju commented on code in PR #10070:
URL: https://github.com/apache/incubator-doris/pull/10070#discussion_r898656705
##########
be/src/vec/columns/column_vector.cpp:
##########
@@ -327,7 +327,7 @@ ColumnPtr ColumnVector<T>::replicate(const
IColumn::Offsets& offsets) const {
// vectorized this code to speed up
IColumn::Offset counts[size];
- for (size_t i = 0; i < size; ++i) {
+ for (ssize_t i = 0; i < size; ++i) {
Review Comment:
We use `offsets[i - 1]` inside this for loop, so it is better to use
`ssize_t` for `index -1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
