zclllyybb commented on code in PR #45926: URL: https://github.com/apache/doris/pull/45926#discussion_r1912951080
########## be/src/vec/functions/dictionary.h: ########## @@ -83,7 +83,8 @@ class IDictionary { template <typename Type> struct ColumnWithType { using DataType = Type; - DataType::ColumnType::Ptr column; + using FieldType = DataType::FieldType; + std::vector<FieldType> column; Review Comment: use `std::vector<FieldType, Allocator_<FieldType>>` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org