gavinchou commented on code in PR #45027: URL: https://github.com/apache/doris/pull/45027#discussion_r1912751134
########## fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4: ########## @@ -395,6 +395,7 @@ unsupportedLoadStatement | RESUME ALL ROUTINE LOAD #resumeAllRoutineLoad | STOP ROUTINE LOAD FOR label=multipartIdentifier #stopRoutineLoad | SHOW ALL? ROUTINE LOAD ((FOR label=multipartIdentifier) | wildWhere?) #showRoutineLoad + | SHOW ROUTINE LOAD IN ALL #showRoutineLoad Review Comment: why not just `show routine load` to get all jobs. we can known whether it is an "all" context if we check the "current db": * if a db is selected by `use xxx`, means show jobs for the db * no db is selected, means we need to show all ########## fe/fe-core/src/main/cup/sql_parser.cup: ########## @@ -2951,6 +2951,10 @@ show_routine_load_stmt ::= {: RESULT = new ShowRoutineLoadStmt(null, true, parser.wild); :} + | KW_SHOW KW_ROUTINE KW_LOAD KW_IN KW_ALL Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org