zhannngchen commented on code in PR #10153:
URL: https://github.com/apache/incubator-doris/pull/10153#discussion_r897807556
##########
be/src/olap/cumulative_compaction_policy.cpp:
##########
@@ -460,16 +461,11 @@ void
NumBasedCumulativeCompactionPolicy::calculate_cumulative_point(
}
void CumulativeCompactionPolicy::pick_candidate_rowsets(
- int64_t skip_window_sec,
const std::unordered_map<Version, RowsetSharedPtr, HashOfVersion>&
rs_version_map,
int64_t cumulative_point, std::vector<RowsetSharedPtr>*
candidate_rowsets) {
- int64_t now = UnixSeconds();
for (auto& it : rs_version_map) {
// find all rowset version greater than cumulative_point and skip the
create time in skip_window_sec
- if (it.first.first >= cumulative_point &&
- ((it.second->creation_time() + skip_window_sec < now)
- // this case means a rowset has been compacted before which is
not a new published rowset, so it should participate compaction
- || (it.first.first != it.first.second))) {
Review Comment:
Ah... you're right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
