eldenmoon commented on code in PR #46639:
URL: https://github.com/apache/doris/pull/46639#discussion_r1909686239
##########
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java:
##########
@@ -629,8 +630,23 @@ private boolean processModifyColumn(ModifyColumnClause
alterClause, OlapTable ol
// TODO:the case where columnPos is not empty has not been
considered
if (columnPos == null && col.getDataType() ==
PrimitiveType.VARCHAR
&& modColumn.getDataType() ==
PrimitiveType.VARCHAR) {
- col.checkSchemaChangeAllowed(modColumn);
- lightSchemaChange =
olapTable.getEnableLightSchemaChange();
+ try {
+ if
(col.getType().isSupportSchemaChangeForCharType(modColumn.getType())) {
Review Comment:
isSupportSchemaChangeForCharType and isSupportSchemaChangeForComplexType
only throw ddl exception, then these try and if logic could be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
