zhiqiang-hhhh commented on code in PR #46375:
URL: https://github.com/apache/doris/pull/46375#discussion_r1908101409
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -5350,8 +5363,20 @@ public LogicalPlan
visitShowTabletStorageFormat(ShowTabletStorageFormatContext c
@Override
public LogicalPlan visitShowQueryProfile(ShowQueryProfileContext ctx) {
- String queryIdPath = stripQuotes(ctx.queryIdPath.getText());
- return new ShowQueryProfileCommand(queryIdPath);
+ String queryIdPath = "/";
Review Comment:
> it looks very similar to function visitShowLoadProfile, maybe we can make
a extraction of same logics
The new created function would need some advanced syntactic feature to
handle `show query profile` and `show load profile` since they are different
classes, and input arg has different type. Maybe we need something like
template to solve the problem. If we go to there, I think code will too
complicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
