yiguolei commented on code in PR #46570:
URL: https://github.com/apache/doris/pull/46570#discussion_r1907443230
##########
be/src/olap/rowset/beta_rowset.cpp:
##########
@@ -190,6 +201,32 @@ Status BetaRowset::load_segment(int64_t seg_id,
segment_v2::SegmentSharedPtr* se
return Status::OK();
}
+Status BetaRowset::_get_segment_num_rows(int64_t seg_id, uint32_t* num_rows) {
+ auto fs = _rowset_meta->fs();
+ if (!fs) {
+ return Status::Error<INIT_FAILED>("get fs failed");
+ }
+
+ DCHECK(seg_id >= 0);
+ auto seg_path = DORIS_TRY(segment_path(seg_id));
+ io::FileReaderOptions reader_options {
Review Comment:
这个地方，我们直接调用segment loader 的load segment 方法，把cache 设置为false，是不是等价的？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
