This is an automated email from the ASF dual-hosted git repository.

dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new 9c7c0041836 [fix](fe) Ignore `removeDroppedFrontends` when fe using 
metadata fail… (#46446)
9c7c0041836 is described below

commit 9c7c0041836368fb7a0e55b5344c13fa11e3e708
Author: Lei Zhang <zhang...@selectdb.com>
AuthorDate: Wed Jan 8 14:56:28 2025 +0800

    [fix](fe) Ignore `removeDroppedFrontends` when fe using metadata fail… 
(#46446)
    
    …ure recovery
    
    * When use `metadata failure recovery` for changing fe ip, met exception
    as follow:
    
    ```
    ERROR (stateListener|29) [Env.transferToMaster():1729] failed to transfer 
to master. progress: replay journal
    com.sleepycat.je.rep.UnknownMasterException: (JE 18.3.12) Could not 
determine master from helpers at:[/172.59.0.1:12010]
            at 
com.sleepycat.je.rep.elections.Learner.findMaster(Learner.java:443) 
~[je-18.3.14-doris-SNAPSHOT.jar:18.3.14-doris-SNAPSHOT]
            at 
com.sleepycat.je.rep.util.ReplicationGroupAdmin.getMasterSocket(ReplicationGroupAdmin.java:186)
 ~[je-18.3.14-doris-SNAPSHOT.jar:18.3.14-doris-SNAPSHOT]
            at 
com.sleepycat.je.rep.util.ReplicationGroupAdmin.doMessageExchange(ReplicationGroupAdmin.java:607)
 ~[je-18.3.14-doris-SNAPSHOT.jar:18.3.14-doris-SNAPSHOT]
            at 
com.sleepycat.je.rep.util.ReplicationGroupAdmin.getGroup(ReplicationGroupAdmin.java:406)
 ~[je-18.3.14-doris-SNAPSHOT.jar:18.3.14-doris-SNAPSHOT]
            at org.apache.doris.ha.BDBHA.removeDroppedMember(BDBHA.java:256) 
~[doris-fe.jar:1.2-SNAPSHOT]
            at 
org.apache.doris.catalog.Env.removeDroppedFrontends(Env.java:3184) 
~[doris-fe.jar:1.2-SNAPSHOT]
            at org.apache.doris.catalog.Env.transferToMaster(Env.java:1597) 
~[doris-fe.jar:1.2-SNAPSHOT]
            at org.apache.doris.catalog.Env.access$1200(Env.java:351) 
~[doris-fe.jar:1.2-SNAPSHOT]
            at org.apache.doris.catalog.Env$5.runOneCycle(Env.java:2885) 
~[doris-fe.jar:1.2-SNAPSHOT]
            at org.apache.doris.common.util.Daemon.run(Daemon.java:119) 
~[doris-fe.jar:1.2-SNAPSHOT]
    ```
---
 fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java 
b/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
index 505970e104c..7e0617a84a0 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
@@ -3179,6 +3179,13 @@ public class Env {
     }
 
     private void removeDroppedFrontends(ConcurrentLinkedQueue<String> 
removedFrontends) {
+        if 
(!Strings.isNullOrEmpty(System.getProperty(FeConstants.METADATA_FAILURE_RECOVERY_KEY)))
 {
+            // metadata recovery mode
+            LOG.info("Metadata failure recovery({}), ignore removing dropped 
frontends",
+                    
System.getProperty(FeConstants.METADATA_FAILURE_RECOVERY_KEY));
+            return;
+        }
+
         if (haProtocol != null && haProtocol instanceof BDBHA) {
             BDBHA bdbha = (BDBHA) haProtocol;
             bdbha.removeDroppedMember(removedFrontends);


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to