yiguolei commented on code in PR #46570: URL: https://github.com/apache/doris/pull/46570#discussion_r1905702029
########## be/src/olap/rowset/rowset_reader.h: ########## @@ -40,7 +40,7 @@ struct RowSetSplits { // if segment_offsets is not empty, means we only scan // [pair.first, pair.second) segment in rs_reader, only effective in dup key // and pipeline - std::pair<int, int> segment_offsets; + std::pair<int64_t, int64_t> segment_offsets; Review Comment: remove get_segment_num_rows method from this class -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org