englefly opened a new pull request, #10099: URL: https://github.com/apache/incubator-doris/pull/10099
# Proposed changes refactor in_list_predicate.cpp 1. use normal cpp code instead of macro definition. 2. remvoe NotInListPredicate class. It is almost duplicated to InListPredicate 3. add bool _in_or_not member in InListPredicate. if _in_or_not=false, InListPredicate stands for former NotInListPredicate. Only rewrite vectorization part. The non-vertorization parts are still in Macros style. remove them when we clean non-verctorization code. Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 3. Has unit tests been added: (Yes/No/No Need) 6. Has document been added or modified: (Yes/No/No Need) 7. Does it need to update dependencies: (Yes/No) 8. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
