jacktengg commented on PR #10080: URL: https://github.com/apache/incubator-doris/pull/10080#issuecomment-1153655751
> @jacktengg hi, why removed the logic that multiple filters only wait 1s at most. Is there a performance loss in the test? > > This is a TODO for the first implementation of the runtime filter. Currently, `ScanNode` will wait at most n seconds, and n is equal to the number of runtime filters, which will cause serious performance loss in extreme cases. No enough test have been done for the change of 'multiple filters only wait 1s at most', so the performance impact is not sure for mutiple runtime filters in on ScanNode. E.g., waiting a RF for 1.5 seconds and it can filter a lot of rows, VS waiting for 1 seconds and the RF is missed, I have not tested this situation, not sure which is better. So in this PR will not include the change of RF waiting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
