This is an automated email from the ASF dual-hosted git repository.
hellostephen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new bbd83c85d6c [fix](regression-test) fix injection would not be removed
when exception (#46357)
bbd83c85d6c is described below
commit bbd83c85d6c8de1cac1d48fda9f455d04d7e130c
Author: hui lai <lai...@selectdb.com>
AuthorDate: Fri Jan 3 14:40:42 2025 +0800
[fix](regression-test) fix injection would not be removed when exception
(#46357)
### What problem does this PR solve?
Fix injection would not be removed when exception.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
---
regression-test/README.md | 2 ++
.../suites/load_p0/routine_load/test_multi_table_load_error.groovy | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/regression-test/README.md b/regression-test/README.md
index 1cc6aca452e..fb7bdde2ee2 100644
--- a/regression-test/README.md
+++ b/regression-test/README.md
@@ -82,6 +82,8 @@ under the License.
7. Do not create the same table in different cases under the same directory to
avoid conflicts.
+8. Cases injected should be marked as nonConcurrent and ensured injection to
be removed after running the case.
+
## Compatibility case
Refers to the resources or rules created on the initial cluster during FE
testing or upgrade testing, which can still be used normally after the cluster
restart or upgrade, such as permissions, UDF, etc.
diff --git
a/regression-test/suites/load_p0/routine_load/test_multi_table_load_error.groovy
b/regression-test/suites/load_p0/routine_load/test_multi_table_load_error.groovy
index 7217109c353..17a8e5da719 100644
---
a/regression-test/suites/load_p0/routine_load/test_multi_table_load_error.groovy
+++
b/regression-test/suites/load_p0/routine_load/test_multi_table_load_error.groovy
@@ -125,7 +125,6 @@ suite("test_multi_table_load_eror","nonConcurrent") {
if (state == "RUNNING") {
count++
if (count > 60) {
-
GetDebugPoint().disableDebugPointForAllBEs(injection)
break;
}
continue;
@@ -150,6 +149,7 @@ suite("test_multi_table_load_eror","nonConcurrent") {
break;
}
} finally {
+ GetDebugPoint().disableDebugPointForAllBEs(injection)
sql "stop routine load for ${jobName}"
sql "DROP TABLE IF EXISTS ${tableName}"
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
