morningman commented on PR #10005: URL: https://github.com/apache/incubator-doris/pull/10005#issuecomment-1151802251
> LGTM. I just didn't get why do we refactor the MetaReader and MetaWriter code. Using reflection makes it a little bit harder to read the code. But it's not a block, just curious. For 2 reason: 1. Use information saved in MetaFooter to load the image, so that we can skip some newly added modules, for forward compatibility.2 2. Use reflect so that we don't need to modify MetaReader and MetaWriter anymore in future, only need to add new method in MetaPersiteMethod. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
