englefly commented on code in PR #46171:
URL: https://github.com/apache/doris/pull/46171#discussion_r1901409020
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RecomputeOutputProcessor.java:
##########
@@ -22,13 +22,14 @@
import org.apache.doris.nereids.trees.plans.physical.AbstractPhysicalPlan;
/**
- * merge consecutive projects
+ * recompute output in logical properties
+ * after join reorder, plan output slot order is changed, recompute them.
*/
-public class RecomputeLogicalPropertiesProcessor extends PlanPostProcessor {
+public class RecomputeOutputProcessor extends PlanPostProcessor {
@Override
public Plan visit(Plan plan, CascadesContext ctx) {
AbstractPhysicalPlan newPlan = (AbstractPhysicalPlan)
visitChildren(this, plan, ctx);
- return ((AbstractPhysicalPlan) newPlan.resetLogicalProperties())
+ return ((AbstractPhysicalPlan) newPlan.reComputeOutput())
Review Comment:
when we implement this rule, logicalProperty only contains output.
but now we have other information (data trait) which can not be recomputed.
So we need to keep datatrait
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
