eldenmoon commented on code in PR #46279: URL: https://github.com/apache/doris/pull/46279#discussion_r1900877662
########## be/src/vec/common/schema_util.cpp: ########## @@ -174,6 +171,15 @@ Status cast_column(const ColumnWithTypeAndName& arg, const DataTypePtr& type, Co return Status::OK(); } + auto function = SimpleFunctionFactory::instance().get_function("CAST", arguments, type); Review Comment: since some branch does not need to execute function,so get the function is useless -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org