yiguolei commented on code in PR #10013: URL: https://github.com/apache/incubator-doris/pull/10013#discussion_r893208553
########## be/src/vec/runtime/vfile_result_writer.h: ########## @@ -0,0 +1,126 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include "runtime/file_result_writer.h" +#include "vec/sink/result_sink.h" + +namespace doris { + +namespace vectorized { +// write result to file +class VFileResultWriter final : public VResultWriter { +public: + VFileResultWriter(const ResultFileOptions* file_option, + const TStorageBackendType::type storage_type, + const TUniqueId fragment_instance_id, + const std::vector<ExprContext*>& output_expr_ctxs, + RuntimeProfile* parent_profile, BufferControlBlock* sinker, + Block* output_block, bool output_object_data, + const RowDescriptor& output_row_descriptor); + virtual ~VFileResultWriter(); + + virtual Status append_block(Block& block) override; + virtual Status append_row_batch(const RowBatch* batch) override { + return Status::NotSupported("append_row_batch is not supported in VFileResultWriter!"); + }; + + virtual Status init(RuntimeState* state) override; + virtual Status close() override; + + // file result writer always return statistic result in one row + virtual int64_t get_written_rows() const override { return 1; } + + std::string gen_types(); + Status write_csv_header(); + +private: + Status _write_csv_file(const Block& block); + + // if buffer exceed the limit, write the data buffered in _plain_text_outstream via file_writer + // if eos, write the data even if buffer is not full. + Status _flush_plain_text_outstream(bool eos); + void _init_profile(); + + Status _create_file_writer(const std::string& file_name); + Status _create_next_file_writer(); + Status _create_success_file(); + // get next export file name + Status _get_next_file_name(std::string* file_name); + Status _get_success_file_name(std::string* file_name); + Status _get_file_url(std::string* file_url); + std::string _file_format_to_name(); + // close file writer, and if !done, it will create new writer for next file. + // if only_close is true, this method will just close the file writer and return. + Status _close_file_writer(bool done, bool only_close = false); + // create a new file if current file size exceed limit + Status _create_new_file_if_exceed_size(); + // send the final statistic result + Status _send_result(); + // save result into batch rather than send it + Status _fill_result_block(); + + RuntimeState* _state; // not owned, set when init + const ResultFileOptions* _file_opts; + TStorageBackendType::type _storage_type; + TUniqueId _fragment_instance_id; + const std::vector<ExprContext*>& _output_expr_ctxs; + + // If the result file format is plain text, like CSV, this _file_writer is owned by this FileResultWriter. + // If the result file format is Parquet, this _file_writer is owned by _parquet_writer. + FileWriter* _file_writer = nullptr; Review Comment: Use unique ptr please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
