gavinchou commented on code in PR #45668:
URL: https://github.com/apache/doris/pull/45668#discussion_r1900424309


##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -3362,4 +3362,8 @@ public static int metaServiceRpcRetryTimes() {
             "For disabling certain SQL queries, the configuration item is a 
list of simple class names of AST"
                     + "(for example CreateRepositoryStmt, 
CreatePolicyCommand), separated by commas."})
     public static String block_sql_ast_names = "";
+
+    public static long meta_service_rpc_reconn_interval_ms = 5000;

Review Comment:
   ```suggestion
       public static long meta_service_rpc_reconnect_interval_ms = 5000;
   ```



##########
fe/fe-core/src/main/java/org/apache/doris/cloud/rpc/MetaServiceProxy.java:
##########
@@ -77,6 +84,16 @@ public static MetaServiceProxy getInstance() {
         return MetaServiceProxy.SingletonHolder.get();
     }
 
+    public boolean needReconn() {
+        lock.lock();
+        try {
+            long now = System.currentTimeMillis();
+            return (now - lastConnTimeMs.element() > 
Config.meta_service_rpc_reconn_interval_ms);

Review Comment:
   ```suggestion
               return (now - lastConnTimeMs.element() > 
Config.meta_service_rpc_reconnect_interval_ms);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to