xinyiZzz commented on code in PR #46136:
URL: https://github.com/apache/doris/pull/46136#discussion_r1899540411
##########
be/src/common/daemon.cpp:
##########
@@ -259,15 +261,39 @@ void refresh_cache_capacity() {
refresh_cache_capacity_sleep_time_ms -=
config::memory_maintenance_sleep_time_ms;
}
-void je_purge_dirty_pages() {
+void je_reset_dirty_decay() {
#ifdef USE_JEMALLOC
- if (je_purge_dirty_pages_sleep_time_ms <= 0 &&
- doris::MemInfo::je_dirty_pages_mem() >
doris::MemInfo::je_dirty_pages_mem_limit() &&
- GlobalMemoryArbitrator::is_exceed_soft_mem_limit()) {
- doris::MemInfo::notify_je_purge_dirty_pages();
- je_purge_dirty_pages_sleep_time_ms = config::memory_gc_sleep_time_ms;
+ if
(doris::MemInfo::je_reset_dirty_decay_notify.load(std::memory_order_relaxed)) {
+ // if not return, je_enable_dirty_page may be modified, but notify is
ignored.
+ return;
+ }
+
+ if (je_reset_dirty_decay_sleep_time_ms <= 0) {
+ bool new_je_enable_dirty_page;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
