amorynan commented on code in PR #45905:
URL: https://github.com/apache/doris/pull/45905#discussion_r1899316282
##########
be/src/vec/exec/format/json/new_json_reader.cpp:
##########
@@ -1818,6 +1816,10 @@ Status
NewJsonReader::_simdjson_write_data_to_column(simdjson::ondemand::value&
} else {
return Status::InternalError("Not support load to complex column.");
}
+ // we should set nullmap at last to avoid column_nullable nullmap and data
column size not same
Review Comment:
According to the original method, we set the nullmap in advance, but if an
exception occurs during the logical process of processing data_column below and
returns, the size of data_column and nullmap in column_nullable will be
inconsistent. Then we catch this exception outter, and call
```_handle_simdjson_error``` which calls column pop_back , in this wrong
ColumnNullable , data_column which is nullptr would cause core
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
