morningman commented on PR #46026: URL: https://github.com/apache/doris/pull/46026#issuecomment-2564996325
This pull request introduces significant enhancements to the `JdbcClickHouseClient` class, including new methods for handling database terms and driver versions, and updates to regression tests to support these changes. The most important changes are summarized below: ### Enhancements to `JdbcClickHouseClient`: * Added methods to determine if the database term is a catalog or schema, including `isDatabaseTermCatalog`, `determineDatabaseTerm`, `isNewClickHouseDriver`, and `getDatabaseTermFromUrl`. These methods ensure compatibility with different driver versions and configurations. * Implemented the `getDatabaseNameList`, `processTable`, `getRemoteColumns`, and `getCatalogName` methods to handle database terms appropriately based on the driver version and URL configuration. ### Updates to `JdbcClient`: * Added a `getJdbcDriverVersion` method to retrieve the JDBC driver version, which is used in the `JdbcClickHouseClient` for determining database term handling. ### Regression Tests: * Updated the `test_clickhouse_jdbc_catalog` regression test suite to include tests for different configurations of the ClickHouse JDBC driver, covering both catalog and schema database terms. This ensures the new functionality is thoroughly tested. [[1]](diffhunk://#diff-975dfaf454c08a92ac11e86ab4dfdd52685417d68c81a0590370d10006fef1e6R29) [[2]](diffhunk://#diff-975dfaf454c08a92ac11e86ab4dfdd52685417d68c81a0590370d10006fef1e6R123-R173) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
