morrySnow commented on code in PR #44789:
URL: https://github.com/apache/doris/pull/44789#discussion_r1897091295
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/DateFormat.java:
##########
@@ -49,6 +54,10 @@ public class DateFormat extends ScalarFunction
FunctionSignature.ret(VarcharType.SYSTEM_DEFAULT).args(DateType.INSTANCE,
VarcharType.SYSTEM_DEFAULT)
);
+ private static final Set<String> monoFormat = ImmutableSet.of("yyyyMMdd",
"yyyy-MM-dd", "yyyy-MM-ddHH:mm:ss",
+ "%Y", "%Y-%m", "%Y-%m-%d", "%Y-%m-%d%H", "%Y-%m-%d%H:%i",
"%Y-%m-%d%H:%i:%s", "%Y-%m-%d%H:%i:%S",
+ "%Y-%m-%d%T", "%Y%m%d", "%Y%m");
Review Comment:
add case that the original format is illegal, such as `yyy yM Md d`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
