morningman commented on code in PR #9915:
URL: https://github.com/apache/incubator-doris/pull/9915#discussion_r887004196
##########
be/src/olap/tablet_manager.cpp:
##########
@@ -636,6 +636,13 @@ TabletSharedPtr
TabletManager::find_best_tablet_to_compaction(
<< ", tablet_id=" << tablet_ptr->tablet_id();
continue;
}
+ if (compaction_type == CompactionType::BASE_COMPACTION &&
Review Comment:
We should make sure that the rowset is large enough to not perform base
comapction. Instead of simply prohibiting base compaction of duplicate tables.
Otherwise we might end up with a lot of small files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
