superdiaodiao commented on code in PR #45830: URL: https://github.com/apache/doris/pull/45830#discussion_r1896462017
########## be/src/vec/functions/function_json.cpp: ########## @@ -833,7 +833,7 @@ struct FunctionJsonQuoteImpl { }; struct FunctionJsonExtractImpl { - static constexpr auto name = "json_extract"; + static constexpr auto name = "json_extract_old"; Review Comment: If the logic of function `json_extract()` is moved to `function_jsonb.cpp`, is it alright to delete this `FunctionJsonExtractImpl` further more? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org